Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(oval/oracle): ignore fips patched version for non fips package versions #2047

Merged
merged 2 commits into from
Nov 8, 2024
Merged

feat(oval/oracle): ignore fips patched version for non fips package versions #2047

merged 2 commits into from
Nov 8, 2024

Conversation

wagde-orca
Copy link
Contributor

@wagde-orca wagde-orca commented Oct 13, 2024 •
edited by MaineK00n
Loading

If this Pull Request is work in progress, Add a prefix of “[WIP]” in the title.

What did you implement:

like the ksplice and TDC in SUSE, we need not to report fips patched versions for non fips packages

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

by unit test

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@wagde-orca
ignore fips patched version for non fips package versions
b151ce4 
like the ksplice and TDC in SUSE, we need not to report fips patched versions for non fips packages
@MaineK00n MaineK00n self-requested a review October 14, 2024 01:37
@wagde-orca
Copy link
Contributor Author

wagde-orca commented Oct 14, 2024 •
edited
Loading

Here is an example of the FP:

This is the installed package: gnutls 3.6.16-8.el8_9.3
        "gnutls": {
            "name": "gnutls",
            "version": "3.6.16",
            "release": "8.el8_9.3",
            "newVersion": "",
            "newRelease": "",
            "arch": "x86_64",
            "repository": "",
            "modularitylabel": ""
        },
and vuls report this CVE
        "CVE-2021-20231": {
            "cveID": "CVE-2021-20231",
            "confidences": [
                {
                    "score": 100,
                    "detectionMethod": "OvalMatch"
                }
            ],
            "affectedPackages": [
                {
                    "name": "gnutls",
                    "fixedIn": "10:3.6.16-4.0.1.el8_fips"
                }
            ],
            "cveContents": {
                "oracle": [
                    {
                        "type": "oracle",
                        "cveID": "CVE-2021-20231",
                        "title": "",
                        "summary": "",
                        "cvss2Score": 0,
                        "cvss2Vector": "",
                        "cvss2Severity": "",
                        "cvss3Score": 0,
                        "cvss3Vector": "",
                        "cvss3Severity": "",
                        "cvss40Score": 0,
                        "cvss40Vector": "",
                        "cvss40Severity": "",
                        "sourceLink": "https://linux.oracle.com/cve/CVE-2021-20231.html",
                        "published": "0001-01-01T00:00:00Z",
                        "lastModified": "0001-01-01T00:00:00Z"
                    }
                ]
            },
            "alertDict": {
                "cisa": null,
                "jpcert": null,
                "uscert": null
            }
        },

@MaineK00n MaineK00n changed the title ignore fips patched version for non fips package versions feat(oval/oracle): ignore fips patched version for non fips package versions Oct 18, 2024
@MaineK00n MaineK00n merged commit c0b267d into future-architect:master Nov 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaineK00n MaineK00n MaineK00n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wagde-orca @MaineK00n